Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-KEM/IND-CPA ] Fix verification #760

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[ML-KEM/IND-CPA ] Fix verification #760

merged 1 commit into from
Jan 22, 2025

Conversation

mamonet
Copy link
Member

@mamonet mamonet commented Jan 20, 2025

This patch increases z3rlimit for certain functions in ind-cpa module to fix verification process

@mamonet mamonet requested a review from a team as a code owner January 20, 2025 18:35
@franziskuskiefer
Copy link
Member

@mamonet what's the state of #713 ? We can merge this one here, or get that one in, right?

@mamonet
Copy link
Member Author

mamonet commented Jan 22, 2025

@mamonet what's the state of #713 ? We can merge this one here, or get that one in, right?

#713 has the same changes that this PR did. We can close this PR if we want to merge #713 soon, I am running make right now on dev-panic-free branch to make sure all modules verify successfully before merging.

@karthikbhargavan
Copy link
Contributor

Yes, I asked for this PR just so that we could fix verification on main, in case 713 needs more changes, but if the rust code over there looks good, then let's merge that one and close this one.

@franziskuskiefer
Copy link
Member

Ok, merging this one. #713 can go on top

@franziskuskiefer franziskuskiefer merged commit f2095f3 into main Jan 22, 2025
58 checks passed
@franziskuskiefer franziskuskiefer deleted the ind-cpa-fix branch January 22, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants