-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for enum predicate methods #816
Conversation
Bump the minimum version after crystal-lang/crystal#15335
Add "Question methods" section and add a different example to Methods section
✅ Deploy Preview for crystal-book ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit 02ff22a.
I changed the target branch to |
Very minor, but would "Predicate methods" be a better title for the section? |
I prefer "Predicate methods" but in https://crystal-lang.org/api/1.15.0/Enum.html#question-methods the used term is "Question methods". So I kept the same name. |
I agree that predicate methods is formally a better term. I'd be happy to change it in both places. Question method also has some benefit as it's very descriptive and easily understandable though 🤔 |
I prefer "Predicate Methods". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do predicate methods then!
Co-authored-by: Johannes Müller <[email protected]>
Add a "Question methods" section porting from https://crystal-lang.org/api/1.15.0/Enum.html#question-methods
Add a different example to Methods section because the current example can lead the reader to think that question methods aren't defined by default.