Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for https (using openssl) #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrialland
Copy link

No description provided.

@csachs
Copy link
Owner

csachs commented Oct 2, 2021

Thanks for the branch! I'm currently quite busy, so some decision will need to be postponed;
generally SSL support is obviously something extremely useful, however since it is security-related, it needs to be done very carefully; and it certainly increases picohttpclient's dependency footprint. My main concern currently would be certificate verification; if done improperly, mitm-attacks might become possible.

@csachs csachs self-assigned this Oct 2, 2021
@jrialland
Copy link
Author

You're welcome :) effectively I have implemented just the bare necessary in order to be able to query the https urls I needed for my own project, it surely cannot be considered production-ready, as you said.

If I ever find the need and the time to add the proper cert validation code, I'll improve on my pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants