Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did it #38

Open
wants to merge 2 commits into
base: solution
Choose a base branch
from
Open

Did it #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
376c198
Add clarifying note to README
joshwcomeau Dec 12, 2022
cc0efad
did it
winhenderson Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ This project uses **CSS Modules**. CSS modules are ultimately very similar to va
import styles from './Something.module.css';

function Something() {
return <div className={styles.wrapper}>I'll be 500px wide!</div>;
return (
<div className={styles.wrapper}>
I'll be 500px wide!
</div>
);
}
```

Expand Down Expand Up @@ -86,6 +90,8 @@ Give the character a minimum height of 500px. On smaller windows, this means the

<img alt="Screenshot of a shorter Chrome window, with the character truncated at the knees" src="./docs/short-window.png" style="width: 100%;" />

> NOTE: If you notice at some point that the character SVG disappears, it's likely because it needs to be given an explicit width/height. This is discussed in more depth on the “Solution” page, https://courses.joshwcomeau.com/css-for-js/02-rendering-logic-2/20-character-workshop-solution#collapsed-svgs

### Exercise 3: Overflow

Each control panel features a number of customizations. For control panels with too many options, a horizontal scrollbar should be introduced:
Expand Down
Loading