Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GOTIFY #6

Merged
merged 6 commits into from
Nov 7, 2024
Merged

use GOTIFY #6

merged 6 commits into from
Nov 7, 2024

Conversation

mikaelmotin
Copy link
Contributor

added gotify for as a contact service

@mikaelmotin mikaelmotin requested a review from Lee4-M March 19, 2024 17:48
Lee4-M

This comment was marked as outdated.

Copy link
Contributor

@Lee4-M Lee4-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix so that run build works

@Lee4-M Lee4-M dismissed their stale review March 19, 2024 17:52

Check was unsucessful

@Lee4-M
Copy link
Contributor

Lee4-M commented Apr 18, 2024

This doesn't work as the environment variable is not exposed when running the check. The workflow needs to be changed to fix this.

@Oscariremma
Copy link
Member

The current way of accessing the ENV variables is statically on compile time which causes the build failure. What we need to do is read them at runtime which is done by doing this

Copy link
Contributor

@Lee4-M Lee4-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Lee4-M Lee4-M merged commit a8a2a94 into main Nov 7, 2024
2 checks passed
@Oscariremma Oscariremma deleted the contactTest branch November 7, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants