Skip to content

Commit

Permalink
BREAKING CHANGE: Support for Node.js 14 was removed
Browse files Browse the repository at this point in the history
  • Loading branch information
ovr committed Dec 15, 2023
1 parent 38101f6 commit 14ac217
Show file tree
Hide file tree
Showing 15 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"url": "https://github.com/cube-js/cube.git"
},
"resolutions": {
"@types/node": "^14",
"@types/node": "^16",
"@types/ramda": "0.27.40"
},
"license": "MIT",
Expand Down
10 changes: 5 additions & 5 deletions packages/cubejs-backend-shared/src/node-check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,24 @@ import color from '@oclif/color';
const currentNodeVersion = process.versions.node;
const semver = currentNodeVersion.split('.');
const major = parseInt(<string> semver[0], 10);
const _minor = parseInt(<string> semver[1], 10);
// const _minor = parseInt(<string> semver[1], 10);

if (major < 14 || major === 15) {
if (major < 16 || major === 15 || major === 17) {
console.error(
color.red(
`You are running Node.js ${currentNodeVersion}.\n` +
'Cube.js CLI requires Node.js 16 or higher \n' +
'Cube.js CLI requires Node.js 18 or higher \n' +
'Please update your Node.js version.'
)
);
process.exit(1);
}

if (major === 14) {
if (major === 16) {
process.emitWarning(
color.red(
`You are running Node.js ${currentNodeVersion}.\n` +
'Support for Node.js 14 will be removed soon. Please upgrade to Node.js 16 or higher.'
'Support for Node.js 16 will be removed soon. Please upgrade to Node.js 16 or higher.'
)
);
}
2 changes: 1 addition & 1 deletion packages/cubejs-druid-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@cubejs-backend/linter": "^0.34.25",
"@types/generic-pool": "^3.1.9",
"@types/jest": "^27",
"@types/node": "^14",
"@types/node": "^16",
"jest": "^27",
"testcontainers": "^8.12",
"typescript": "~5.2.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-duckdb-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@cubejs-backend/linter": "^0.34.25",
"@cubejs-backend/testing-shared": "^0.34.35",
"@types/jest": "^27",
"@types/node": "^14",
"@types/node": "^16",
"jest": "^27",
"typescript": "~5.2.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-jdbc-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@cubejs-backend/linter": "^0.34.25",
"@cubejs-backend/shared": "^0.34.33",
"@types/generic-pool": "^3.1.9",
"@types/node": "^14",
"@types/node": "^16",
"@types/sqlstring": "^2.3.0",
"typescript": "~5.2.2"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-mongobi-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"dependencies": {
"@cubejs-backend/base-driver": "^0.34.33",
"@cubejs-backend/shared": "^0.34.33",
"@types/node": "^14",
"@types/node": "^16",
"generic-pool": "^3.6.0",
"moment": "^2.29.1",
"mysql2": "^2.3.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@cubejs-client/core": "^0.34.32",
"@cubejs-client/react": "^0.34.32",
"@types/flexsearch": "^0.7.3",
"@types/node": "^14",
"@types/node": "^16",
"@types/react": "^17.0.3",
"@types/react-beautiful-dnd": "^13.0.0",
"@types/react-dom": "^17.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-query-orchestrator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@types/generic-pool": "^3.1.9",
"@types/ioredis": "^4.19.3",
"@types/jest": "^27",
"@types/node": "^14",
"@types/node": "^16",
"@types/ramda": "^0.27.32",
"@types/redis": "^2.8.28",
"@types/uuid": "^8.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-schema-compiler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@types/inflection": "^1.5.28",
"@types/jest": "^27",
"@types/lru-cache": "^5.1.0",
"@types/node": "^14",
"@types/node": "^16",
"@types/ramda": "^0.27.34",
"@types/sqlstring": "^2.3.0",
"@types/syntax-error": "^1.4.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-server-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@types/jest": "^27",
"@types/jsonwebtoken": "^8.5.0",
"@types/lru-cache": "^5.1.0",
"@types/node": "^14",
"@types/node": "^16",
"@types/node-fetch": "^2.5.7",
"@types/ramda": "^0.27.34",
"@types/uuid": "^8.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@types/body-parser": "^1.19.0",
"@types/cors": "^2.8.8",
"@types/express": "^4.17.11",
"@types/node": "^14",
"@types/node": "^16",
"@types/semver": "^7.3.4",
"@types/ws": "^7.2.9",
"@types/yarnpkg__lockfile": "^1.1.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-testing-drivers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@cubejs-client/ws-transport": "^0.34.32",
"@jest/globals": "^27",
"@types/jest": "^27",
"@types/node": "^14",
"@types/node": "^16",
"dotenv": "^16.0.3",
"fs-extra": "^11.1.1",
"jest": "^27",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-testing-shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@jest/globals": "^27",
"@types/dedent": "^0.7.0",
"@types/jest": "^27",
"@types/node": "^14",
"@types/node": "^16",
"jest": "^27",
"typescript": "~5.2.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-testing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"@types/dedent": "^0.7.0",
"@types/http-proxy": "^1.17.5",
"@types/jest": "^27",
"@types/node": "^14",
"@types/node": "^16",
"cypress": "6.9.1",
"cypress-image-snapshot": "^4.0.1",
"cypress-localstorage-commands": "^1.4.5",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7584,10 +7584,10 @@
dependencies:
"@types/node" "*"

"@types/node@*", "@types/[email protected]", "@types/node@>=12.12.47", "@types/node@>=13.7.0", "@types/node@^12", "@types/node@^12.12.17", "@types/node@^14":
version "14.18.37"
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.37.tgz#0bfcd173e8e1e328337473a8317e37b3b14fd30d"
integrity sha512-7GgtHCs/QZrBrDzgIJnQtuSvhFSwhyYSI2uafSwZoNt1iOGhEN5fwNrQMjtONyHm9+/LoA4453jH0CMYcr06Pg==
"@types/node@*", "@types/[email protected]", "@types/node@>=12.12.47", "@types/node@>=13.7.0", "@types/node@^12", "@types/node@^12.12.17", "@types/node@^14", "@types/node@^16":
version "16.18.68"
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.68.tgz#3155f64a961b3d8d10246c80657f9a7292e3421a"
integrity sha512-sG3hPIQwJLoewrN7cr0dwEy+yF5nD4D/4FxtQpFciRD/xwUzgD+G05uxZHv5mhfXo4F9Jkp13jjn0CC2q325sg==

"@types/normalize-package-data@^2.4.0":
version "2.4.1"
Expand Down

0 comments on commit 14ac217

Please sign in to comment.