feat: Timestamp subtraction, epoch extraction from intervals #8346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
paveltiunov
changed the title
paveltiunov
approved these changes
Jun 14, 2024
…_interval Includes test cases that pass but should fail, due to formatting in IntervalValue::as_postgresql_str and misconstructed IntervalValues in batch_to_dataframe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This updates a git commit pointer to arrow-datafusion for cube-js/arrow-datafusion#158 and adds tests.
Some test values are rendered pretty screwily because of another bug outside the scope of this feature, involving formatting in IntervalValue::as_postgresql_str and misconstructed IntervalValues in batch_to_dataframe. That needs to be fixed but is seemingly a separate issue.
Edit: The test values will be fixed in the branch interval-rendering.