Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Oracle Database Free #8383

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Upgrade to Oracle Database Free #8383

merged 1 commit into from
Jun 28, 2024

Conversation

gvenzl
Copy link
Contributor

@gvenzl gvenzl commented Jun 24, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]
Hey all,

Thanks a lot for using my Oracle Database images.
I have noticed that you are still using the old Oracle Database XE version of my images.

Oracle has discontinued Oracle Database XE and instead offers Oracle Database Free as the successor, which was first released last year.

The database editions are compatible, hence nothing should break or change other than the connect string and the Docker image tag.

I have taken the liberty to provide the modifications based on what I could find in the repository.

Thanks,

@gvenzl gvenzl requested a review from a team as a code owner June 24, 2024 02:36
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 2:37am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jun 24, 2024
@igorlukanin
Copy link
Member

Thanks for the heads-up and your PR @gvenzl! Much appreciated!

@ovr ovr assigned ovr and unassigned paveltiunov Jun 25, 2024
@ovr ovr merged commit 9956fd9 into cube-js:master Jun 28, 2024
35 of 37 checks passed
@ovr
Copy link
Member

ovr commented Jun 28, 2024

Thank you, @gvenz, for your contribution! 🍰 🚀

@gvenzl
Copy link
Contributor Author

gvenzl commented Jul 2, 2024

Thanks for merging the change! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants