Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CI Workflow updates #8387

Merged
merged 21 commits into from
Jul 1, 2024
Merged

chore: CI Workflow updates #8387

merged 21 commits into from
Jul 1, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 24, 2024

We have too many outdated actions. Some use super old node versions. Here is an attempt to update all actions to the latest.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/restore@v3, nick-invision/retry@v2
.....

Also updated obsolete echo "::save-state name={name}::{value}". More info can be found here

Also this fixes all shellcheck warnings across workflows

And to keep our workflows clean and correct — this PR adds new workflow linter.

This PR includes:

  • chore(ci): update actions/setup-node action to latest
  • chore(ci): update nick-invision/retry action to nick-fields/retry as it was moved
  • chore(ci): update set-output (deprecated) to use $GITHUB_OUTPUT
  • chore(ci): update allenevans/set-env action to latest
  • chore(ci): update actions/cache action to latest
  • chore(ci): update actions-rs/toolchain to actions-rust-lang/setup-rust-toolchain
  • chore(ci): update docker/* actions to latest
  • chore(ci): update artifact-related actions to latest
  • chore(ci): update macos-13 in CI jobs
  • chore(ci): remove unused os versions from job matrix in birdbox
  • chore(ci): remove rustup workaround on non-windows jobs
  • chore(ci): update xom9ikk/dotenv action to latest
  • chore(ci): update actions/github-script action to latest
  • chore(ci): remove matrix.before_script steps because there is no before_script parameter defined in the matricies
  • chore(ci): remove unused RUNNER_TRACKING_ID in push job
  • chore(ci): fix SC2086/SC2046 shellcheck warnings: double quote to prevent globbing and word splitting
  • chore(ci): fix SC2035 shellcheck warning (use ./glob or -- glob so names with dashes won't become options)
  • chore(ci): fix SC2086/SC2046 shellcheck warnings: double quote to prevent globbing and word splitting
  • chore(ci): fix SC2129 shellcheck warnings: Consider using { cmd1; cmd2; } >> file instead of individual redirects

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 10:05am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jun 24, 2024
@KSDaemon KSDaemon force-pushed the ci-wf-updates branch 6 times, most recently from 0760ac0 to 01e0ac7 Compare June 25, 2024 15:19
@KSDaemon KSDaemon force-pushed the ci-wf-updates branch 2 times, most recently from 5a57927 to 1945b1c Compare June 26, 2024 15:29
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KSDaemon KSDaemon force-pushed the ci-wf-updates branch 4 times, most recently from d4fea4b to c4a2b78 Compare June 27, 2024 10:03
@paveltiunov paveltiunov changed the title CI Workflow updates chore: CI Workflow updates Jun 27, 2024
@KSDaemon KSDaemon merged commit be318c3 into master Jul 1, 2024
87 checks passed
@KSDaemon KSDaemon deleted the ci-wf-updates branch July 1, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants