fix(schema-compiler): use toDateTime64 for pre-1970 dates CH #8390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
|
Thanks for your contribution @Ilex4524 🙌 It would be great if @paveltiunov or @ovr can take a look at these changes. |
…ckHouseQuery adapter to handle dates before 1970
Ilex4524
force-pushed
the
fix/datetime64-clickhouse-adapter
branch
from
0b1ad9f to
d1c4603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This PR updates the ClickHouseQuery adapter to replace all instances of
toDateTimewithtoDateTime64. This change ensures that dates before 1970 are handled correctly, particularly in time dimensions functionality.Important Note for Users:
If your dataset includes dates before 1970, ensure that the
enable_extended_results_for_datetime_functionsClickHouse option is turned on. This setting is crucial for functions liketoStartOfYearto work correctly with dates outside the typical range.For more information, refer to the ClickHouse documentation.