feat: Make graceful shutdown add fatal messages in postgres #8402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also contains modifications to make the graceful shutdown process wait for graceful shutdown actions to finish.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
paveltiunov
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from fatal error message injection, we also add logic to wait on and properly join the postgres connections and tasks. Otherwise we would not properly gracefully shut down.
One easily reversible decision made was to avoid passing the CancellationToken down recursively and instead track partially written socket buffers. Because we have other CancellationTokens floating around in query logic (which IIRC are not actually used -- nothing triggers them) that might have a reason to change in the future.