-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-gateway): add meta about query in gql #8410
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Hi @nurulhudaapon 👋 Thanks for your contribution! I see that you not only add Do I understand correctly that If the goal is to allow requesting |
Hi @igorlukanin, sorry for the confusion about the /meta API, this is different and only adds metadata about query result. I've updated the PR title, description and also updated the doc to align on what it does. Let me know if it is clearer now. Thanks. |
Hi @paveltiunov, sorry for tagging, just was looking if it's possible to get this in. |
@igorlukanin This is kind of blocking us from adding pagination with single API call when using GraphQL, having this available sooner will be greatly appreciated. |
Check List
Description of Changes Made (if issue reference is not provided)
This PR adds
extensions.meta
which is equivalent to all metadata about query result that is available via the REST API /load endpoint. The load endpoint returns metadata such astotal
and others but these were not available through the graphql API.Here is an example of getting total/query-meta from GraphQL API:
Query:
Response:
So this PR is enabling feature like getting the
total
via GraphQL API which wasn't possible previously and opens up adding other metadata if needed.