feat(cubestore): Support IAM role authentication for S3 #8589
+91
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
github-actions
bot
added
the
pr:community
|
@igorlukanin it is not clear why the Vercel test is failing. I am interested in this feature and could work on the tests to make it acceptable and suitable for merging. |
|
I've rebased this PR on top of the latest and it looks like we have more build steps failing now. Could anyone please take a look? |
I can have a look. I think I can fix the error for the failing checks. |
leopepe
suggested changes
Jan 21, 2025
| @@ -101,6 +101,7 @@ humansize = "2.1.3" | |||
| deepsize = "0.2.0" | |||
| anyhow = "1.0" | |||
| arc-swap = "1.7.1" | |||
| aws_sdk_sts = "1.38.0" | |||
There was a problem hiding this comment.
Suggested change
| aws_sdk_sts = "1.38.0" | |
| aws-sdk-sts = "1.38.0" |
Comment on lines
+64
to
+66
| Some(role_name) => { | ||
| assume_role(&role_name, ®ion.to_string()).await | ||
| } |
There was a problem hiding this comment.
Suggested change
| Some(role_name) => { | |
| assume_role(&role_name, ®ion.to_string()).await | |
| } | |
| Some(role_name) => assume_role(&role_name, ®ion.to_string()).await, |
Comment on lines
+118
to
+121
| .assume_role(AssumeRoleRequest::builder() | ||
| .role_arn(format!("arn:aws:iam::{}:role/{}", account_id, role_or_access_key)) | ||
| .duration_seconds(28800) | ||
| .build()) |
There was a problem hiding this comment.
Suggested change
| .assume_role(AssumeRoleRequest::builder() | |
| .role_arn(format!("arn:aws:iam::{}:role/{}", account_id, role_or_access_key)) | |
| .duration_seconds(28800) | |
| .build()) | |
| .assume_role( | |
| AssumeRoleRequest::builder() | |
| .role_arn(format!( | |
| "arn:aws:iam::{}:role/{}", | |
| account_id, role_or_access_key | |
| )) | |
| .duration_seconds(28800) | |
| .build(), | |
| ) |
Comment on lines
+128
to
+129
| let access_key = assume_role_output.access_key_id.ok_or_else(|| CubeError::internal("Failed to get access key".to_string()))?; | ||
| let secret_key = assume_role_output.secret_access_key.ok_or_else(|| CubeError::internal("Failed to get secret key".to_string()))?; |
There was a problem hiding this comment.
Suggested change
| let access_key = assume_role_output.access_key_id.ok_or_else(|| CubeError::internal("Failed to get access key".to_string()))?; | |
| let secret_key = assume_role_output.secret_access_key.ok_or_else(|| CubeError::internal("Failed to get secret key".to_string()))?; | |
| let access_key = assume_role_output | |
| .access_key_id | |
| .ok_or_else(|| CubeError::internal("Failed to get access key".to_string()))?; | |
| let secret_key = assume_role_output | |
| .secret_access_key | |
| .ok_or_else(|| CubeError::internal("Failed to get secret key".to_string()))?; |
| let fs = match fs.upgrade() { | ||
| None => { | ||
| log::debug!("Stopping S3 credentials refresh loop"); | ||
| return; | ||
| } | ||
| Some(fs) => fs, | ||
| }; | ||
|
|
||
| let (access_key, secret_key) = if is_role { | ||
| let (access_key, secret_key) = assume_role(&role_or_access_key.as_ref().unwrap(), ®ion.to_string()).await; |
There was a problem hiding this comment.
Suggested change
| let (access_key, secret_key) = assume_role(&role_or_access_key.as_ref().unwrap(), ®ion.to_string()).await; | |
| let (access_key, secret_key) = | |
| assume_role(&role_or_access_key.as_ref().unwrap(), ®ion.to_string()).await; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need IAM role authentication, similar to this issue #6795.
Check List
Issue Reference this PR resolves
Add IAM role authentication.
Description of Changes Made (if issue reference is not provided)
Introduce
CUBESTORE_AWS_IAM_ROLEandCUBESTORE_AWS_IAM_REFRESH_EVERY_MINS.If there is
CUBESTORE_AWS_IAM_ROLEin the env, we would generate ID and secret on the flight.Since this ID is short-lived (15 mins by default), we would need a shorten refresh loop.