Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server-core): Support for scheduledRefreshTimeZones as function, passing securityContext #9002

Merged
merged 17 commits into from
Dec 18, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 28, 2024

This PR brings the ability to provide a scheduledRefreshTimeZones function as an alternative to a static timezone string array. This allows us to dynamically set the timezones used for the pre-aggregation refresh job. This is pretty neat for multi-tenant configurations allowing to specify different timezones for different tenants.

Closes #3509, #5015

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 7:46pm

@KSDaemon KSDaemon force-pushed the feat/scheduledRefreshTimeZones branch 3 times, most recently from 0a32483 to e4bba5b Compare November 28, 2024 19:45
@KSDaemon KSDaemon marked this pull request as ready for review November 28, 2024 20:38
@KSDaemon KSDaemon requested a review from a team as a code owner November 28, 2024 20:38
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (95021f2) to head (37d8d17).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9002   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files         221      221           
  Lines       78813    78813           
=======================================
+ Hits        65299    65300    +1     
+ Misses      13514    13513    -1     
Flag Coverage Δ
cubesql 82.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSDaemon KSDaemon force-pushed the feat/scheduledRefreshTimeZones branch from 9a37858 to a14b1bb Compare December 9, 2024 14:41
@KSDaemon KSDaemon force-pushed the feat/scheduledRefreshTimeZones branch from cf28dd2 to 8d8dc33 Compare December 11, 2024 20:49
@KSDaemon KSDaemon requested a review from a team as a code owner December 11, 2024 21:25
@KSDaemon KSDaemon force-pushed the feat/scheduledRefreshTimeZones branch from eae02a5 to d2ca1d1 Compare December 11, 2024 21:27
@KSDaemon KSDaemon merged commit 10e47fc into master Dec 18, 2024
81 checks passed
@KSDaemon KSDaemon deleted the feat/scheduledRefreshTimeZones branch December 18, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-tenancy aware Time Zones
3 participants