Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cubesql): Fix clippy warnings in cubesql, part 1 #9052

Merged
merged 25 commits into from
Jan 17, 2025

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Just a bunch of small clippy fixes around the codebase, targeted to enable more rules

@mcheshkov mcheshkov changed the title Fix clippy warnings in cubesql, part 1 refactor(cubesql): Fix clippy warnings in cubesql, part 1 Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (bde6eea) to head (674dab6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/pg-srv/src/buffer.rs 64.70% 6 Missing ⚠️
...t/cubesql/cubesql/src/compile/engine/udf/common.rs 80.00% 2 Missing ⚠️
rust/cubesql/cubesql/src/compile/router.rs 75.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/sql/postgres/shim.rs 83.33% 1 Missing ⚠️
rust/cubesql/cubesql/src/sql/statement.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9052   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files         225      225           
  Lines       80553    80531   -22     
=======================================
- Hits        66992    66977   -15     
+ Misses      13561    13554    -7     
Flag Coverage Δ
cubesql 83.16% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the cubesql-clippy-1 branch 2 times, most recently from a31cde7 to 01285d5 Compare January 16, 2025 14:39
@mcheshkov mcheshkov marked this pull request as ready for review January 16, 2025 15:47
@mcheshkov mcheshkov requested a review from a team as a code owner January 16, 2025 15:47
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Cool!

@mcheshkov mcheshkov merged commit 0341c85 into master Jan 17, 2025
68 checks passed
@mcheshkov mcheshkov deleted the cubesql-clippy-1 branch January 17, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants