Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema-compiler): make sure view members are resolvable in DAP #9059

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bsod90
Copy link
Member

@bsod90 bsod90 commented Dec 18, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@bsod90 bsod90 requested review from a team as code owners December 18, 2024 18:50
@bsod90 bsod90 requested a review from paveltiunov December 18, 2024 18:50
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 18, 2024
@bsod90 bsod90 force-pushed the fix_dap_filter_evaluation_in_views branch from d15a5cc to 5ca1f76 Compare December 18, 2024 19:13
@bsod90 bsod90 force-pushed the fix_dap_filter_evaluation_in_views branch 2 times, most recently from e48f493 to 84d1489 Compare January 13, 2025 19:40
@bsod90 bsod90 force-pushed the fix_dap_filter_evaluation_in_views branch 4 times, most recently from 80385a5 to 551c4bc Compare January 29, 2025 23:08
@bsod90 bsod90 requested a review from igorlukanin January 30, 2025 19:15
@bsod90 bsod90 force-pushed the fix_dap_filter_evaluation_in_views branch from 551c4bc to 1487b20 Compare January 30, 2025 19:17
@bsod90 bsod90 merged commit e7b992e into master Feb 4, 2025
51 checks passed
@bsod90 bsod90 deleted the fix_dap_filter_evaluation_in_views branch February 4, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants