Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(presto-driver): Optimize testConnection() to issue <get Nodes()> instead of heavy show catalogs query #9109

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(presto-driver): Optimize testConnection() to issue <get Nodes()> instead of heavy show catalogs query #9109

merged 1 commit into from
Jan 23, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jan 17, 2025 •
edited
Loading

Use get nodes() REST API Request query for testing connection instead of a heavy one show catalogs like ?

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon requested a review from a team as a code owner January 17, 2025 14:29
@KSDaemon KSDaemon changed the title fix(presto-driver): optimize testConnection() to issue simple select 1 test instead of heavy show catalogs fix(presto-driver): Optimize testConnection() to issue simple select 1 test instead of heavy show catalogs Jan 17, 2025
@KSDaemon KSDaemon force-pushed the fix/presto-test-connection branch from 0949d69 to 3b02131 Compare January 17, 2025 20:35
@KSDaemon KSDaemon changed the title fix(presto-driver): Optimize testConnection() to issue simple select 1 test instead of heavy show catalogs fix(presto-driver): Optimize testConnection() to issue <get Nodes()> instead of heavy show catalogs query Jan 17, 2025
@KSDaemon KSDaemon merged commit 6d6df53 into master Jan 23, 2025
27 checks passed
@KSDaemon KSDaemon deleted the fix/presto-test-connection branch January 23, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johancube johancube johancube approved these changes

@ifokeev ifokeev ifokeev approved these changes

@mcheshkov mcheshkov mcheshkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KSDaemon @mcheshkov @ifokeev @johancube