Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema-compiler): move create table name check to underlying driver for Postgres, MySQL, Oracle #9112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(schema-compiler): move create table name check to underlying driver for Postgres, MySQL, Oracle #9112

wants to merge 3 commits into from
+81 −12

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jan 17, 2025 •
edited
Loading

The check for the table name length is been moved to the driver from query class, thus it is enforced
ony for specific datasources.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review January 17, 2025 18:39
@KSDaemon KSDaemon requested a review from a team as a code owner January 17, 2025 18:39
@KSDaemon KSDaemon force-pushed the fix/tbl-name-check-drivers branch from 23b3c18 to 955a3fb Compare January 21, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KSDaemon