Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Fix condition for joining two date range filters #9113

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@mcheshkov mcheshkov force-pushed the fix-date-range-filters-panic branch from 764a26b to bbaf0df Compare January 18, 2025 01:24
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (9ae9035) to head (aec5d51).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9113      +/-   ##
==========================================
+ Coverage   83.02%   83.03%   +0.01%     
==========================================
  Files         225      226       +1     
  Lines       79430    79482      +52     
==========================================
+ Hits        65947    66000      +53     
+ Misses      13483    13482       -1     
Flag Coverage Δ
cubesql 83.03% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review January 20, 2025 10:24
@mcheshkov mcheshkov requested a review from a team as a code owner January 20, 2025 10:24
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@mcheshkov mcheshkov force-pushed the fix-date-range-filters-panic branch from bbaf0df to aec5d51 Compare January 20, 2025 21:39
@mcheshkov mcheshkov merged commit 39190e0 into master Jan 20, 2025
68 checks passed
@mcheshkov mcheshkov deleted the fix-date-range-filters-panic branch January 20, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants