Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snowflake-driver): set QUOTED_IDENTIFIERS_IGNORE_CASE=FALSE by default #9172

Merged
merged 1 commit into from
Feb 3, 2025
Merged

feat(snowflake-driver): set QUOTED_IDENTIFIERS_IGNORE_CASE=FALSE by default #9172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,12 +453,7 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {

await this.execute(connection, 'ALTER SESSION SET TIMEZONE = \'UTC\'', [], false);
await this.execute(connection, `ALTER SESSION SET STATEMENT_TIMEOUT_IN_SECONDS = ${this.config.executionTimeout}`, [], false);

// We only want to ignore the case if someone sets the value to true explicitly
// since the default assumption is that casing matters
if (this.config.identIgnoreCase) {
await this.execute(connection, 'ALTER SESSION SET QUOTED_IDENTIFIERS_IGNORE_CASE = TRUE', [], false);
}
await this.execute(connection, `ALTER SESSION SET QUOTED_IDENTIFIERS_IGNORE_CASE = ${this.config.identIgnoreCase}`, [], false);
return connection;
} catch (e) {
this.connection = null;
Expand Down
Loading