Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our little homegrown arena library, called
pool
, is a little like id-arena or similar, but with special stuff we need for our "zero-copy" use case.Previously, it was implemented as special traits that extend plain old Rust types like
&[T]
andVec<T>
. This was convenient in some ways but got confusing and prevented some fancier convenience features. I've now wrapped these in newtypesStore
andPool
that let us more carefully control the interface to the arenas. This should be less error-prone in the long run. As an added bonus, it makes it easier to access pools with subscripting: for example,gfa.segs[id]
works whereid
has typeId<Segment>
.