Avoid allocations when handling reverse-complement sequence data #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to @AndreaGuarracino's #196, this tries to avoid allocating any buffers for reverse-complements until the last possible second (before printing). Seems to come with a minor but not enormous performance benefit, just for printing.
The idea is to introduce a structure that wraps the underlying
&[u8]buffer and a flag for reversals. Then, the only actually do the reverse-complement-ing when weDisplay. Index trickery makes it possible to treat this new type mostly as if it were an eagerly-computed string.