Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use padding instead of margin on Content #5444

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

dougmacknz
Copy link
Contributor

@dougmacknz dougmacknz commented Jan 10, 2025

Why

The new responsive TabList was interfering with this. See https://cultureamp.slack.com/archives/C0189KBPM4Y/p1736373685188149

What

Adjust the Content component to use padding instead of margin for adding inline spacing.

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 7bafa6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougmacknz dougmacknz marked this pull request as ready for review January 10, 2025 01:20
@dougmacknz dougmacknz requested a review from a team as a code owner January 10, 2025 01:20
Copy link
Contributor

github-actions bot commented Jan 10, 2025

✨ Here is your branch preview! ✨

Last updated for commit 7bafa6c: Merge branch 'main' into KZN-2943/content-margin-to-padding

Copy link
Contributor

@mcwinter07 mcwinter07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in my book. We could convert it to CSS too but will leave that as an optional update 😉

Copy link
Contributor

@ryanseddon ryanseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dougmacknz dougmacknz merged commit 8160df5 into main Jan 10, 2025
19 checks passed
@dougmacknz dougmacknz deleted the KZN-2943/content-margin-to-padding branch January 10, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants