Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow consumers to supply configuration options beyond input an… #5493

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

diffidentDude
Copy link
Contributor

…d plugins

Important: Request PR reviews on Slack

Please reach out to the design system team on Slack in #prod_design_system for PR reviews. GitHub notifications (e.g. from tagging a person) are not actively monitored.

Why

I'm working on a package that needs more fine grained control of the rollup config. This change is to allow consumers to override the default configuration if needed.

What

@diffidentDude diffidentDude requested a review from a team as a code owner February 2, 2025 23:42
Copy link

changeset-bot bot commented Feb 2, 2025

🦋 Changeset detected

Latest commit: 4d2bb8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/package-bundler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@diffidentDude diffidentDude force-pushed the package_bundler_config branch from a908199 to 3afc6f9 Compare February 3, 2025 01:36
Copy link
Contributor

@ckychris ckychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a comment in Slack to explore other solutions before exposing the full rollup API. https://cultureamp.slack.com/archives/C0189KBPM4Y/p1738540325962639

@diffidentDude diffidentDude force-pushed the package_bundler_config branch from 5a19e53 to 8421241 Compare February 3, 2025 02:47
Copy link
Contributor

github-actions bot commented Feb 3, 2025

✨ Here is your branch preview! ✨

Last updated for commit 4d2bb8d: feat: revert previous and accept a new treeshake param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants