Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ownerships table not showing creator when no results #969

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Fixed ownerships table not showing creator when no results #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a80925
Pass missing creator prop to OwnershipsTable
Anahkiasen Jan 29, 2025
648a550
Render both empty state and table with creator when no ownerships
Anahkiasen Jan 29, 2025
b1171a7
Linting
Anahkiasen Jan 29, 2025
331d11e
Remove empty state under ownerships table altogether
Anahkiasen Feb 3, 2025
cf8695d
Update to v4 of Artifacts action
Anahkiasen Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
AUTH_CLIENT_SECRET: ${{ secrets.AUTH_CLIENT_SECRET }}

run: yarn test:e2e
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down
5 changes: 1 addition & 4 deletions src/pages/organizers/[organizerId]/ownerships/OwnershipsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
OwnershipRequest,
OwnershipState,
} from '@/hooks/api/ownerships';
import { Alert, AlertVariants } from '@/ui/Alert';
import { Button, ButtonVariants } from '@/ui/Button';
import { Icons } from '@/ui/Icon';
import { Inline } from '@/ui/Inline';
Expand Down Expand Up @@ -95,10 +96,6 @@ export const OwnershipsTable = ({
[requests],
);

if (requests.length === 0) {
return <Text>{t('organizers.ownerships.table.no_results')}</Text>;
}

return (
<Stack
role="table"
Expand Down
1 change: 1 addition & 0 deletions src/pages/organizers/[organizerId]/ownerships/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ const Ownership = () => {
<OwnershipsTable
requests={approvedRequests}
onDelete={setRequestToBeDeleted}
creator={creator}
/>
<Modal
title={t('organizers.ownerships.delete_modal.title')}
Expand Down
Loading