Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MONEY logo to Base network #572

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

0xonerb
Copy link
Contributor

@0xonerb 0xonerb commented Oct 16, 2024

No description provided.

Copy link
Contributor

Changes are required before your pull request can be reviewed:

  • Error with .gitignore: Only additions of token icons (in the /images folder) or platform logos (in the /platforms folder) are permitted

@0xonerb
Copy link
Contributor Author

0xonerb commented Oct 16, 2024

Changes are required before your pull request can be reviewed:

  • Error with .gitignore: Only additions of token icons (in the /images folder) or platform logos (in the /platforms folder) are permitted

I don't understand why ignore the images folder? cc @philippe-git

See: https://github.com/curvefi/curve-assets/blob/main/.gitignore#L23

@philippe-git
Copy link
Member

I don't understand why ignore the images folder? cc @philippe-git

See: https://github.com/curvefi/curve-assets/blob/main/.gitignore#L23

Yeah me neither, @bout3fiddy is this required or just there because a gitignore was populated like this when you setup token lists generation?

@0xonerb merging your pr anyway, ty!

@philippe-git philippe-git merged commit 0ec1397 into curvefi:main Oct 17, 2024
1 of 2 checks passed
@0xonerb 0xonerb deleted the base-money-logo branch October 17, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants