Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to node 22 #628

Merged
merged 10 commits into from
Feb 10, 2025
Merged

chore: update to node 22 #628

merged 10 commits into from
Feb 10, 2025

Conversation

DanielSchiavini
Copy link
Contributor

@DanielSchiavini DanielSchiavini commented Jan 24, 2025 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:05pm
curve-dapp-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:05pm

0xAlunara
0xAlunara previously approved these changes Jan 24, 2025
View reviewed changes
@DanielSchiavini
Copy link
Contributor Author

trying to fix the runtime error in curvefi/curve-js#442

@DanielSchiavini
Copy link
Contributor Author

DanielSchiavini commented Jan 28, 2025 •
edited
Loading

Still some asserts crashing the dex app. Located them here.
Fixing in curvefi/ethcall#5

0xAlunara
0xAlunara previously approved these changes Feb 8, 2025
View reviewed changes
@DanielSchiavini DanielSchiavini changed the base branch from main to chore/next February 10, 2025 09:21
@DanielSchiavini DanielSchiavini marked this pull request as ready for review February 10, 2025 09:22
Base automatically changed from chore/next to main February 10, 2025 10:28
@DanielSchiavini DanielSchiavini dismissed 0xAlunara’s stale review February 10, 2025 10:28

The base branch was changed.

0xtutti
0xtutti previously approved these changes Feb 10, 2025
View reviewed changes
@0xAlunara 0xAlunara merged commit bbbbfa6 into main Feb 10, 2025
5 checks passed
@0xAlunara 0xAlunara deleted the chore/node branch February 10, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xAlunara 0xAlunara 0xAlunara approved these changes

@OnlyJousting OnlyJousting OnlyJousting approved these changes

@0xtutti 0xtutti 0xtutti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielSchiavini @0xAlunara @OnlyJousting @0xtutti