Merge pull request #2 from GAntoine:parse-misconfigured-license-objects

Attempt to parse misconfigured license declaration

lib/parseLicense.js

@@ -10,10 +10,18 @@ function parse (file) {
       return handleUndefinedAndNull(file.license.type)
     }
   }
-  
+
   if (file.licenses !== undefined) {
-    return handleUndefinedAndNull(file.licenses[0].type)
+    if (Array.isArray(file.licenses)) {
+      return handleUndefinedAndNull(file.licenses[0].type)
+    }
+
+    if (typeof file.licenses === 'object') {
+      return handleUndefinedAndNull(file.licenses.type)
+    }
   }
+
+  return handleUndefinedAndNull(undefined)
 }
 
 function handleUndefinedAndNull (licenseString) {

tests/dummy/package.misconfiguredObjectType.json

@@ -0,0 +1,3 @@
+{
+  "licenses": {"type": "LMAO"}
+}

tests/dummy/package.stringType.json

@@ -0,0 +1,3 @@
+{
+  "license": "BRB"
+}

tests/parseLicense.test.js

@@ -13,6 +13,15 @@ describe('test `license` export', () => {
     )
   })
 
+  test('test the output of an string that is identified by `license`', () => {
+    const pkg = loadPackagejson.sync(`${__dirname}/dummy/package.stringType.json`)
+    const actual = parseLicense(pkg)
+
+    expect(actual).toEqual(
+      'BRB'
+    )
+  })
+
   test('test the output of an object that is identified by `license` which has a `type` property', () => {
     const pkg = loadPackagejson.sync(`${__dirname}/dummy/package.objectType.json`)
     const actual = parseLicense(pkg)
@@ -22,4 +31,21 @@ describe('test `license` export', () => {
     )
   })
 
+  test('test the output of an array that is identified by `licenses` but misconfigured as a single object', () => {
+    const pkg = loadPackagejson.sync(`${__dirname}/dummy/package.misconfiguredObjectType.json`)
+    const actual = parseLicense(pkg)
+
+    expect(actual).toEqual(
+      'LMAO'
+    )
+  })
+
+  test('test the output of a missing license object is informative placeholder text', () => {
+    const actual = parseLicense({})
+
+    expect(actual).toEqual(
+      'invalid license'
+    )
+  })
+
 })