Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pycolmap.Reconstruction for model converter. Add colmap visualizer with the same backend (Open3D) #121

Merged
merged 14 commits into from
Jan 9, 2025

Conversation

B1ueber2y
Copy link
Member

@B1ueber2y B1ueber2y commented Jan 8, 2025

Reopening #119

  • Switch to pycolmap.Reconstruction from the deprecated namedcollections and remove PyReadCOLMAP
  • Add some additional Python tests in the tests folder. Set up pytest and add it to CI. We should migrate the e2e test in the tests folder as well, but this will require merging the dataset implementation into the limap package. To run the tests locally
pytest -m ci_workflow tests/
  • Add colmap visualizer with the same Open3D backend, to make the visualization consistent with the line maps. Also support robust ranges to prune outlier points.

@B1ueber2y B1ueber2y merged commit abb923e into main Jan 9, 2025
4 checks passed
@B1ueber2y B1ueber2y deleted the features/pycolmap_recon branch January 9, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants