Skip to content
This repository has been archived by the owner on Dec 16, 2019. It is now read-only.

Don't modify creation date when editing bookmark via api #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pascalfree
Copy link
Contributor

Hi.

When changing a bookmark with the API, the only way to do this is via posts/add?replace=yes&....
When editing a bookmark the expected behaviour is, that the creation date is unchanged and the modification date will change.

Currently both dates are changed when using the api function. A workaround would be to send a date dt=..., but then the modification date is not accurate, it will be set to the same date as the new creation date.

With this pull request, when replace=yes is set, the bookmark will be "updated" and the dt option will be ignored. This is compatible to the delicious api.

I wrote a test for that, which passed in my setup.

I'm creating a new pull request for this (instead of using #9) because, this seems like a bug, that should be fixed in the current api.
I will fix it in the new api as well.

@cweiske
Copy link
Owner

cweiske commented Nov 5, 2014

Good idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants