Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onyx 26897 retry #186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Onyx 26897 retry #186

wants to merge 2 commits into from

Conversation

Pooja-Gangwar
Copy link
Contributor

@Pooja-Gangwar Pooja-Gangwar commented Jan 7, 2023

Desired Outcome

The ansible-lookup-plugin does not support retries

Implemented Changes

Code fix is around supporting re-tries with authentication.
Create a mock test which can return 401 on first call and returns a token on subsequent call to prove re-try logic.

Connected Issue/Story

Jira ticket - ONYX-26897
Bug - https://cyberark.lightning.force.com/lightning/r/Case/5002J00001Y4ffFQAR/view

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

Pooja Gangwar added 2 commits January 7, 2023 14:48
@Pooja-Gangwar Pooja-Gangwar requested a review from a team as a code owner January 7, 2023 10:21
@Pooja-Gangwar Pooja-Gangwar changed the title Onyx 26897 retried Onyx 26897 retry Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant