Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonapp dockerhub #369

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Demonapp dockerhub #369

merged 5 commits into from
Aug 10, 2021

Conversation

NaomiHaser
Copy link
Contributor

What does this PR do?

Able to use cyberark/demo-app directly from DockerHub instead of building a custom image

What ticket does this PR close?

Resolves #318

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

Manual tests

If you are preparing for a release, have you run the following manual tests to verify existing functionality continues to function as expected?

@NaomiHaser NaomiHaser marked this pull request as ready for review August 10, 2021 17:42
@NaomiHaser NaomiHaser requested review from a team as code owners August 10, 2021 17:42
Copy link
Contributor

@imheresamir imheresamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NaomiHaser NaomiHaser merged commit 5a9d8e9 into master Aug 10, 2021
@imheresamir imheresamir deleted the demonapp-dockerhub branch August 10, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Workflow Scripts: Use cyberark/demo-app directly from DockerHub instead of building a custom image
2 participants