Bump version to 1.1.1 #268
Conversation
|
thanks for getting this @izgeri ! |
|
@cyberark/palmtree to get this green, I had to remove a hardcoded version in one of your test scripts. so, two things:
thanks! |
| @@ -26,4 +26,4 @@ $cli_with_timeout "get RoleBinding secrets-provider-role-binding" | |||
| $cli_with_timeout "get ConfigMap cert-config-map" | |||
|
|
|||
| # Validate that the Secrets Provider took the default image configurations if not supplied and was deployed successfully | |||
| $cli_with_timeout "describe job secrets-provider | grep 'cyberark/secrets-provider-for-k8s:1.1.0'" | awk '{print $2}' && $cli_with_timeout "get job secrets-provider -o jsonpath={.status.succeeded}" | |||
| $cli_with_timeout "describe job secrets-provider | grep 'cyberark/secrets-provider-for-k8s'" | awk '{print $2}' && $cli_with_timeout "get job secrets-provider -o jsonpath={.status.succeeded}" | |||
There was a problem hiding this comment.
@izgeri there needs to be a version here because we need to validate that the SP container took the default which is defined in the values.yaml. So in our case now, we want to verify that 1.1.1 is the version deployed and not 1.1.0. We planned on making a function to fetch the values.yaml but never got around to it.
Anywho, we don't want to leave it without a version because if 1.1.0 by accident was taken then the tests would pass
There was a problem hiding this comment.
if you don't have the bandwidth then I think it would be best to add back the 1.1.1 and open an issue to fetch the tag from value.yaml that way, the test still has meaning. WDYT?
There was a problem hiding this comment.
Filed #270 - I'll fix this now and also add a reference to this file in the CONTRIBUTING release notes now.
Is there a way to control if its code related changes or MD related. Nonetheless, for me, it isn't critical and most of the times it can be cumbersome to catch the person who did the review if you just changed a MD or added a comment in the code. |
In test 22 there is a hardcoded dependency on the secrets provider version. This commit updates that dependency and adds this file to the list of files that need to be updated in CONTRIBUTING. I've also filed an issue to remove this hardcoded dependency in the future.
izgeri
force-pushed
the
bump-version-1.1.1
branch
from
d44eebd to
0d54504
Compare
|
Code Climate has analyzed commit 0d54504 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.5%. View more on Code Climate. |
What does this PR do?
Prepares for a 1.1.1 release.
What ticket does this PR close?
Resolves #267
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or