-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version and changelogs to 2023.1.2 #891
Conversation
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Unfortunately, the required ROS2 tests / industrial_ci (main, humble) is failing consistently, although the same test passes on rolling (but not iron where it fails as well). Can you look into it? |
Hi @omichel , I don't think changes in this PR could cause new CI failures so the failures must have come via previously merged commits? The CI failures are due to tests failings. 2024-02-02T13:54:51.6761473Z ======================================================================
2024-02-02T13:54:51.6761741Z FAIL: testMovement (test_system_tiago.TestTiago)
2024-02-02T13:54:51.6762117Z ----------------------------------------------------------------------
2024-02-02T13:54:51.6762317Z Traceback (most recent call last):
2024-02-02T13:54:51.6763006Z File "/root/target_ws/src/webots_ros2/webots_ros2_tests/test/test_system_tiago.py", line 90, in testMovement
2024-02-02T13:54:51.6763765Z self.wait_for_messages(self.__node, Odometry, '/odom', condition=on_message_received, timeout=60*5)
2024-02-02T13:54:51.6764510Z File "/root/target_ws/src/webots_ros2/webots_ros2_tests/webots_ros2_tests/utils.py", line 56, in wait_for_messages
2024-02-02T13:54:51.6765416Z self.assertGreaterEqual(len(received_messages), messages_to_receive, 'Not enough messages have been received')
2024-02-02T13:54:51.6765981Z AssertionError: 0 not greater than or equal to 1 : Not enough messages have been received I'm simply trying to get Rolling unblocked and don't have the bandwidth to fix any tests here . If it's okay with you I'd like to suggest the following:
We are actively working on migrating Rolling to Ubuntu 24.04 and the next Rolling sync is planned for 6th Feb as mentioned here https://discourse.ros.org/t/preparing-for-rolling-sync-2024-02-06/35882 |
I am fine with your proposal. You can go ahead. |
See #892 (comment) |
Once this is merged, I can tag master as
2023.1.2
and bloom a new release into Rolling to unblock the sync.