set is_urdf_loaded__ of the resource manager to true #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's probably needed after ros-controls/ros2_control@385293e fixes #893
|
Thank you. That seems to fix the problem indeed. The ROS2 tests are now passing on humble (main)! |
omichel
approved these changes
Feb 15, 2024
|
noob question if you will, @omichel - how long until |
The release is blocked by several test failures on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's probably needed after ros-controls/ros2_control@385293e
fixes #893
Description
After, ros-controls/ros2_control@385293e, init_services() won't be called unless is_urdf_loaded__ is set to true. Passing robot description again led to controller name duplicate error.
Related Issues
This pull-request fixes issue #893
Affected Packages
List of affected packages:
Tasks
Add the list of tasks of this PR.