Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: unserve long-time deprecated SubNamespace API versions #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Feb 23, 2025

These API versions were deprecated in #128, and we've had multiple releases since then.

The v1 version is causing trouble in our clusters after upgrading to Flux 2.5. We are still trying to find the root cause for this, but it seems like there are mysterious upstream code. Example: https://github.com/kubernetes/client-go/blob/master/restmapper/discovery.go#L47-L48. Since v1 SubNamespace has a controversial non-standard status, this currently gives errors like this in our clusters:

health check failed after 3m0.016039541s: timeout waiting for: [SubNamespace/stas/stas-k8s-openapi-kustomizor status: 'Unknown': looking up status.observedGeneration from resource: .status.observedGeneration accessor error: ok is of the type string, expected map[string]interface, SubNamespace/stas/stas-review status: 'Unknown': looking up status.observedGeneration from resource: .status.observedGeneration accessor error: ok is of the type string, expected map[string]interface, SubNamespace/stas/stas-spiffe-example status: 'Unknown': looking up status.observedGeneration from resource: .status.observedGeneration accessor error: ok is of the type string, expected map[string]interface]

Hopefully, making v1 unserved could fix this, and I am going to attempt this as a temporary workaround until this change is merged and released.

@erikgb erikgb force-pushed the unserve-old-sn-apis branch from 427b91d to 400f8f1 Compare February 23, 2025 19:04
@erikgb erikgb marked this pull request as ready for review February 23, 2025 19:14
@rkwmt rkwmt requested a review from zoetrope February 25, 2025 01:12
@erikgb
Copy link
Contributor Author

erikgb commented Feb 25, 2025

Update: The root cause for the Flux problem is found, ref. fluxcd/kustomize-controller#1373. We have unserved old/deprecated SubNamepace APIs by patching the CRD in all our clusters as a temporary workaround. I would love to remove this patching eventually, so looking forward to a review and merge of this PR.

Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants