feat!: unserve long-time deprecated SubNamespace API versions #154
+10
−128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These API versions were deprecated in #128, and we've had multiple releases since then.
The v1 version is causing trouble in our clusters after upgrading to Flux 2.5. We are still trying to find the root cause for this, but it seems like there are mysterious upstream code. Example: https://github.com/kubernetes/client-go/blob/master/restmapper/discovery.go#L47-L48. Since v1 SubNamespace has a controversial non-standard status, this currently gives errors like this in our clusters:
Hopefully, making v1 unserved could fix this, and I am going to attempt this as a temporary workaround until this change is merged and released.