Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/23: add secret command group with get & gen-random sub-commands #25

Merged
merged 12 commits into from
Jan 15, 2025

Conversation

narenaryan
Copy link
Collaborator

@narenaryan narenaryan commented Jan 6, 2025

Description

This PR introduces a new command group called secret with sub-commands get, gen-random.

  1. get: Audit a secret from a vault
  2. gen-random: Generate a crypto-safe random sequence to use for rotated keys.
  3. Improve help texts for all commands
  4. Unit tests for new commands

Manual tests

AWS - ✅
Azure - ✅
GCP - ✅

@narenaryan narenaryan added the enhancement New feature or request label Jan 6, 2025
@narenaryan narenaryan self-assigned this Jan 6, 2025
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12781546696

Details

  • 39 of 72 (54.17%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-5.4%) to 74.528%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whispr/about.py 0 1 0.0%
src/whispr/cli.py 0 32 0.0%
Totals Coverage Status
Change from base Build 12500360172: -5.4%
Covered Lines: 237
Relevant Lines: 318

💛 - Coveralls

@narenaryan narenaryan changed the title [DRAFT] feat/23: add initial version of get secret (AWS) [DRAFT] feat/23: add secret command group with get & gen-random sub-commands Jan 15, 2025
@narenaryan narenaryan changed the title [DRAFT] feat/23: add secret command group with get & gen-random sub-commands feat/23: add secret command group with get & gen-random sub-commands Jan 15, 2025
@narenaryan narenaryan merged commit d487dfd into main Jan 15, 2025
2 checks passed
@narenaryan narenaryan deleted the feat/23 branch January 15, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants