Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot assume order of packaged material #612

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

nuclearkatie
Copy link
Contributor

The order of packaged material isn't guaranteed. When checking resources going through packaging, need to check them as a vector and not as exact order. This PR updates the affected tests.

This is also being changed in cyclus tests, in cyclus#1750.

Closes #611

Copy link

github-actions bot commented Jun 12, 2024

Build Status Report - ee40b8c - 2024-06-12 00:33:24 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️

@nuclearkatie nuclearkatie marked this pull request as ready for review June 12, 2024 00:38
@gonuke
Copy link
Member

gonuke commented Jun 12, 2024

Does this mean it all works now?

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down @nuclearkatie

@gonuke gonuke merged commit 1a670d2 into cyclus:main Jun 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish workflow fails but build/test workflow succeeds since #610
2 participants