Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactor and sink keep packaging #618

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Reactor and sink keep packaging #618

merged 5 commits into from
Jul 31, 2024

Conversation

nuclearkatie
Copy link
Contributor

Closes #615

@nuclearkatie nuclearkatie requested a review from gonuke July 19, 2024 20:32
@nuclearkatie nuclearkatie self-assigned this Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

Build Status Report - 65d04c7 - 2024-07-31 20:55:07 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️

@nuclearkatie
Copy link
Contributor Author

nuclearkatie commented Jul 23, 2024

Ok I'm running into a bit of a challenge writing tests here... All I need to do is create packaged material to pass into a reactor facility. But, mock sims don't support packaging. Ok, it's not that hard to add packaging to mock sim source. But mock sim sources are agent:Source, not cycamore:Source, so they don't have packaging.

There's basically three ways I see

  1. Add packaging to agent:Source and Mock Sim
  2. Create a version of Mock Sim that can spin up cycamore archetypes (Source or Storage) as ancillary agents (i.e. what is currently limited to MockSim:AddSource MockSim:AddSink
  3. Create a version of Mock Sim that can create more than one testing archetype (right now a Mock Sim is initialized with up to one agent spec
  4. Just run a whole simulation

Because I'm testing of the keep_packaging parameter in ResBuf (cyclus#1778), do I need testing here?

This PR does require cyclus#1778 to be merged first

@nuclearkatie nuclearkatie changed the title Reactor keep packaging Reactor and sink keep packaging Jul 24, 2024
@nuclearkatie nuclearkatie marked this pull request as ready for review July 31, 2024 19:39
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to use the boolean quantities for defaults, assuming we can

src/reactor.cc Outdated Show resolved Hide resolved
src/reactor.h Outdated Show resolved Hide resolved
src/sink.cc Outdated Show resolved Hide resolved
src/sink.h Outdated Show resolved Hide resolved
@gonuke
Copy link
Member

gonuke commented Jul 31, 2024

Thanks @nuclearkatie

@gonuke gonuke merged commit 5eafa6c into cyclus:main Jul 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep packaging upon receipt for Reactor
2 participants