Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and document utility functions #77

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Refactor and document utility functions #77

merged 6 commits into from
Mar 15, 2024

Conversation

cygnet3
Copy link
Owner

@cygnet3 cygnet3 commented Mar 13, 2024 •
edited
Loading

Improve the logic from the utils functions, which are now part of the crate.
Also adds documentation.

@cygnet3 cygnet3 force-pushed the refactor-utils branch 6 times, most recently from 7c83c3c to 0744dc5 Compare March 13, 2024 19:07
@cygnet3 cygnet3 changed the title WIP Refactor utils functions Refactor utils functions Mar 13, 2024
@cygnet3 cygnet3 changed the title Refactor utils functions Refactor and document utility functions Mar 13, 2024
cygnet3 added 4 commits March 13, 2024 20:37
@cygnet3
Refactor sender and receiver util functions
a4f3ff8 
Move get_a_sum_secret_keys to library from tests

refactor calculating recipient tweak data

refactor calculating partial secret
@cygnet3
Remove utils feature
743c0ce
@cygnet3
Refactor vector tests
60bcadd
@cygnet3
Add documentation to utils functions
da3c60f
@Sosthene00
Copy link
Contributor

tested ACK
But I have some reservation about having utils module scattered between a utils.rs file in src + a utils directory, looking at it I think a big chunk of what's in utils.rs actually fit in receiving and almost all of the rest would be some hash.rs submodule.

@cygnet3
Copy link
Owner Author

cygnet3 commented Mar 15, 2024

Changed it so only the consts are now in the utils.rs file, and the rest is in either utils/receiving.rs or utils/hash.rs

@cygnet3 cygnet3 merged commit dc36924 into master Mar 15, 2024
2 checks passed
@cygnet3 cygnet3 deleted the refactor-utils branch March 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cygnet3 @Sosthene00