Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast: report invalid settings #6574

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

  • We already report invalid cycle points and namespaces.
  • However, we have been relying on client-side validation for settings (which doesn't apply to the GraphQL mutation).
  • This also raises the potential for inter-version compatibility issues going unreported.
  • This commit explicitly handles invalid settings in the same way as invalid cycle points and namespaces so that they are reported back to the user.
  • Closes the issue part of command validation: broadcasts #6429.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* We already report invalid cycle points and namespaces.
* However, we have been relying on client-side validation for settings
  (which doesn't apply to the GraphQL mutation).
* This also raises the potential for inter-version compatibility issues
  going unreported.
* This commit explicitly handles invalid settings in the same way as
  invalid cycle points and namespaces so that they are reported back to
  the user.
* Closes the issue part of cylc#6429.
@oliver-sanders oliver-sanders added the could be better Not exactly a bug, but not ideal. label Jan 24, 2025
@oliver-sanders oliver-sanders self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant