Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-select: fix compatibility with force-condemned hosts #6643

Open
wants to merge 1 commit into
base: 8.4.x
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

Supersedes #6623

Fix an issue with host-select which prevented us from condemning hosts in "force mode".

Also, better link into the "auto restart" docs which can be found here: https://cylc.github.io/cylc-doc/stable/html/plugins/main-loop/built-in/cylc.flow.main_loop.auto_restart.html#module-cylc.flow.main_loop.auto_restart

I am not going to go applying terminology changes to this long-standing feature as part of this bugfix (out of scope).

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Feb 28, 2025
@oliver-sanders oliver-sanders added this to the 8.4.2 milestone Feb 28, 2025
@oliver-sanders oliver-sanders self-assigned this Feb 28, 2025
Comment on lines +134 to +135
if host.endswith('!'):
host = host[:-1]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this line is covered by the test amended in this PR (confirm by running it on master), however, that test is not run in CI due to it's shared filesystem setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant