Upgrade Sass #1995
Open
Upgrade Sass #1995
+295
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
added
dependencies
MetRonnie
commented
Nov 15, 2024
| @@ -79,7 +79,7 @@ | |||
| "json-server": "0.17.4", | |||
| "nodemon": "3.1.7", | |||
| "nyc": "17.1.0", | |||
| "sass": "1.77.8", | |||
| "sass-embedded": "1.80.6", | |||
There was a problem hiding this comment.
https://www.npmjs.com/package/sass-embedded
This package is an alternative to the
sasspackage. It supports the same JS
API assassand is maintained by the same team, but where thesasspackage
is pure JavaScript,sass-embeddedis instead a JavaScript wrapper around a
native Dart executable.
MetRonnie
commented
Nov 15, 2024
| @@ -15,8 +15,7 @@ | |||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
| @use '../settings.scss'; | |||
| @import '@lumino/default-theme/style/index.css'; | |||
There was a problem hiding this comment.
Moved to JS import, as this seems to be falling back to CSS @import instead of Sass @import, and was no longer working as desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1975, fixes the deprecation warnings it brings
vuetifyjs/vuetify#20489 (comment)
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.