[FIX] Fixed jmap quota display #1296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There an other issue that i'l correct: |
Shadow243
force-pushed
the
fix-jmap-quota
branch
from
90b7b31
to
cddcc84
Compare
Shadow243
force-pushed
the
fix-jmap-quota
branch
3 times, most recently
from
d97d6da
to
c5b5205
Compare
I just added |
Shadow243
force-pushed
the
fix-jmap-quota
branch
from
c5b5205
to
bf6bdf0
Compare
kroky
reviewed
Oct 24, 2024
| if ($max > 0) { | ||
| $this->out('quota', ceil(($current / $max) * 100)); | ||
| $this->out('quota_max', $max / 1024); | ||
| if($imap instanceof Hm_JMAP) { |
There was a problem hiding this comment.
Please unify the interface/data scheme for both IMAP and JSON, so the corresponding methods in those classes return the same data structure, then the handler can just use it and not distinguish between the two. This will be particularly helpful in the light of the upcoming EWS support which will use a 3rd set of data representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://www.rfc-editor.org/rfc/rfc9425.pdf
Add
get_quota_rootto hm-jmap.php to correct errorUncaught Error: Call to undefined method Hm_JMAP::get_quota_root