Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the sidebar for a modern look and feel #1313

Merged
merged 9 commits into from
Nov 5, 2024

Conversation

jacob-js
Copy link
Member

@jacob-js jacob-js commented Nov 2, 2024

Further enhancements could be made. If anyone would like to help, the following points need attention:

  • Content such as the changes notice button, debug mode, and logout button are misplaced.
  • The link to the home page should not be in the sidebar as an item, instead, it should be accessible via the app logo.
  • The hide folders icon down in the sidebar, should not be present on mobile viewports. On desktop screens, it has to be replaced by something similar to the menu toggle button on mobile screens. Handled by #1347

@jacob-js jacob-js force-pushed the tweak-sidebar branch 4 times, most recently from 4a8d964 to 6644663 Compare November 5, 2024 11:44
@jacob-js jacob-js marked this pull request as ready for review November 5, 2024 12:58
@jacob-js jacob-js merged commit 7a4a4d4 into cypht-org:master Nov 5, 2024
6 checks passed
@josaphatim
Copy link
Member

@jacob-js thank for this. But can you fix the logo on dark themes (such as darkly theme) as it is not visible ?

@jacob-js
Copy link
Member Author

jacob-js commented Nov 6, 2024

@josaphatim This PR doesn't make the sidebar perfect, please feel free to change whatever you think should be changed for the greater good, including the logo on dark themes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants