Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pnpm v10 install allowlist pnpm.onlyBuiltDependencies instructions #6072

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jan 8, 2025

Issue

[email protected], released Jan 7, 2025 includes a breaking change:

Lifecycle scripts of dependencies are not executed during installation by default!

cypress needs to be added to the allowlist for pnpm life cycle scripts in package.json, for instance using the following:

  "pnpm": {
    "onlyBuiltDependencies": ["cypress"]
  }

Change

The installation instructions for Cypress with pnpm are updated to include references to the pnpm documentation:

Note

Currently, executing npm install pnpm@latest --global installs pnpm@9.

The pnpm installation document instructions for using npm currently lists npm install -g pnpm@latest-10 for pnpm@10.

According to the pnpm maintainer https://github.com/orgs/pnpm/discussions/8945#discussioncomment-11775139 this is for a temporary burn-in period. Sooner or later pnpm@latest will be equivalent to [email protected].

Copy link

netlify bot commented Jan 8, 2025

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f7092f3

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 8, 2025 13:11
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 This is a lot upfront in prime real estate before showing the install commands. Can we make this a note somehow after the install commands show?

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

This is a lot upfront in prime real estate before showing the install commands.

I agree and I had some misgivings when I submitted this PR.

Can we make this a note somehow after the install commands show?

I don't think there is a clean way to just add this text without doing some restructuring of the page. I will put together some change suggestions for the page in a new issue, so you can comment upfront before any PR gets worked on.

In the meantime I will demote this PR to draft.

@MikeMcC399 MikeMcC399 marked this pull request as draft January 11, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm v10 blocks Cypress binary installation by default
3 participants