Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README Docker section #913

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

  1. The GitHub Markdown extension: Alert [!NOTE] is rendered literally in the README as displayed on the npm registry instead of being interpreted.
  2. Use of Docker working directory /e2e has been changed to the neutral /app directory in the examples in the https://github.com/cypress-io/cypress-docker-images repo.
  3. The bookmark https://github.com/cypress-io/cypress-docker-images/blob/master/README.md#tag-selection was changed to #tags

Change

  1. Replace [!NOTE] with the simple text NOTE: so that it renders correctly on the npm registry.
  2. Replace the Docker working directory /e2e with the neutral /app directory in the examples.
  3. Replace the bookmark https://github.com/cypress-io/cypress-docker-images/blob/master/README.md#tag-selection using the bookmark #tags.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 self-assigned this Dec 4, 2024
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 4, 2024 09:04
@jennifer-shehane jennifer-shehane merged commit 8075ec9 into cypress-io:master Dec 4, 2024
12 checks passed
@MikeMcC399 MikeMcC399 deleted the update/docker-interactive branch December 4, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants