Skip to content

Commit

Permalink
Use maps::parse_filtered() for process symbolization
Browse files Browse the repository at this point in the history
In general not all entries in /proc/[pid]/maps are of interest to us and
we perform some pre-filtering based on somewhat coarse grained criteria.
However, for one reason or another we didn't do that in the
symbolization logic, only when normalizing. Having failed to surface why
that is, exactly, let's switch over to using the filtered version
nonetheless, as none of our tests fail with the filtered version. Do so
should speed up things a bit and make follow-on changes easier to
digest.

Signed-off-by: Daniel Müller <[email protected]>
  • Loading branch information
d-e-s-o committed Feb 6, 2025
1 parent eadbeee commit 01e7200
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/symbolize/symbolizer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ impl Symbolizer {
perf_map: bool,
map_files: bool,
) -> Result<Vec<Symbolized>> {
let mut entry_iter = maps::parse(pid)?;
let mut entry_iter = maps::parse_filtered(pid)?;
let entries = |_addr| entry_iter.next();

let mut handler = SymbolizeHandler {
Expand Down

0 comments on commit 01e7200

Please sign in to comment.