Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Eremetic framework fix #1688

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

gisjedi
Copy link
Contributor

@gisjedi gisjedi commented Feb 1, 2018

#1684: Resolves issue of framework id being specified with a '/' in the name. Prohibits specifying / in the framework-name config.json field.

Copy link
Contributor

@surdy surdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surdy
Copy link
Contributor

surdy commented Feb 2, 2018

Thanks @gisjedi

@ryadav88 I did not realize that it was not default package but the users input that lead to bad framework ID. At any rate good to have this validation. Do we have external facing documentation on guiding package contributors ? If yes then it would be a good to document this there.

@ryadav88
Copy link
Contributor

ryadav88 commented Feb 2, 2018

@surdy we have a general tutorial but not for best practices. https://github.com/mesosphere/universe/blob/version-3.x/docs/tutorial/GetStarted.md

@ryadav88 ryadav88 merged commit 6aa3c60 into d2iq-archive:version-3.x Feb 2, 2018
@gisjedi gisjedi deleted the eremetic-framework-fix branch February 2, 2018 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants