Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vpce for different services #7

Merged
merged 12 commits into from
Sep 25, 2024

Conversation

alubneuski
Copy link
Contributor

Description

https://d3b.atlassian.net/jira/software/c/projects/AD/boards/138?assignee=5b27c502835f7165ffe2f22e&selectedIssue=AD-884

Created several services within VPC that is required for any VPC that is deployed on CHOP account.

  • 🔒 Added route table to output, to allow to create VPCE
  • 🎉 Added SecretsManager VPC Endpoint
  • 📝 Fixed typo in the resource name
  • 📝 Updated tag
  • 🎉 Added ECR endpoint as well
  • ❌ Removed ECR
  • 🔧 Updated secrets manager endpoint
  • 🔧 Added ECR DKR and API
  • 🔧 Service type Gateway is not available for SecretsManager vpc endpoint
  • 🔧 Added CloudWatch Endpoint
  • 🔧 Updated the name for the endpoint

Copy link
Member

@devbyaccident devbyaccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alubneuski alubneuski merged commit 28cb41e into master Sep 25, 2024
1 check passed
@alubneuski alubneuski deleted the feature/al/add-route-tables-to-output branch September 25, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants